Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frint-react: Move subscription to componentDidMount in observe HoC #417

Open
fahad19 opened this issue Apr 11, 2018 · 1 comment
Open

frint-react: Move subscription to componentDidMount in observe HoC #417

fahad19 opened this issue Apr 11, 2018 · 1 comment
Labels
help wanted

Comments

@fahad19
Copy link
Member

fahad19 commented Apr 11, 2018

At the moment, it's happening in componentWillMount, which is not recommended.
@fahad19
Copy link
Member Author

fahad19 commented Apr 20, 2018

check if using create-subscription package (maintained by React team in their monorepo) can help us here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fahad19