Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing sub-packages? #30

Closed
frissyn opened this issue Mar 9, 2022 · 0 comments · Fixed by #31
Closed

Missing sub-packages? #30

frissyn opened this issue Mar 9, 2022 · 0 comments · Fixed by #31
Assignees
Labels
tag: important type: bug Something isn't working

Comments

@frissyn
Copy link
Owner

frissyn commented Mar 9, 2022

Upon installing valorant.py from PyPI and importing it, an error is immediately thrown:

Traceback (most recent call last):
  File "main.py", line 1, in <module>
    import valorant
  File "/opt/virtualenvs/python3/lib/python3.8/site-packages/valorant/__init__.py", line 3, in <module>
    from .client import Client
  File "/opt/virtualenvs/python3/lib/python3.8/site-packages/valorant/client.py", line 9, in <module>
    from .objects import (
ModuleNotFoundError: No module named 'valorant.objects'

Not the best look. 🤦🏽 I forgot to include valorant.objects and valorant.local into the packages attribute in setup.py. My fault for pushing a major release at 1am on a school night =P

@frissyn frissyn added type: bug Something isn't working tag: important labels Mar 9, 2022
@frissyn frissyn self-assigned this Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: important type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant