[WIP] Add test for #748

[alfonsogarciacaro]

I cannot get the tests to run locally, neither for netcore or netfx, I see this:

Could not load file or assembly 'nunit.framework, Version=2.6.3.13283, Culture=neutral, PublicKeyToken=96d09a
1eb7f44a77' or one of its dependencies. The system cannot find the file specified.

Cannot run the new test in FSI either. I see this:

> ``add files with same name from different folders`` ()
- ;;
dllName = "test.dll", args = [|"--simpleresolution"; "--noframework"; "--debug:full"; "--define:DEBUG";
  "--optimize-"; "--out:test.dll"; "--doc:test.xml"; "--warn:3"; "--fullpaths";
  "--flaterrors"; "--target:library";
  "c:\Users\Alfonso\dev\FSharp.Compiler.Service\tests\service/data/samename/folder1/a.fs";
  "c:\Users\Alfonso\dev\FSharp.Compiler.Service\tests\service/data/samename/folder2/a.fs";
  "-r:C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5\mscorlib.dll";
  "-r:C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5\System.dll";
  "-r:C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5\System.Core.dll";
  "-r:C:\Program Files (x86)\Reference Assemblies\Microsoft\FSharp\.NETFramework\v4.0\4.4.0.0\FSharp.Core.dll
"|]
System.IO.FileNotFoundException: Could not load file or assembly 'System.ValueTuple, Version=4.0.1.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified.

Let's see what CI says, then.

[alfonsogarciacaro]

The test is failing :(

[alfonsogarciacaro]

Wow, I can't believe this. Monkey patching worked first time! As @forki expected, FCS is not hitting the place where he put the fix for fcs.exe. After some navigation I copy & pasted the fix where it looked more plausible, but I'm not sure. @dsyme Could you please have a look? I don't know if I put the seen dictionary in the best place, it becomes a private member of IncrementalBuilder as I couldn't find a place to access all the ParsedInputs at once as in fsc.fs.

The best news is: it's working with Fable! Now I can go to sleep ;)

[forki]

Don't forget to reintegrate that back to VF# again. Lol

[vasily-kirichenko]

A single (cached, may be discarded) instance of IncrementalBuilder is created for each project, so it looks like a right place for seen cache.

[alfonsogarciacaro]

@vasily-kirichenko Thanks for the comment. I assume this also means that IncrementalBuilder.ParseTask won't be accessing seen from a different thread.

Now that you say that @forki, I realize that we may have the opposite problem: fsc doesn't hit the code in this PR. So we have two options:

• Keep the fix in the two places so it applies to both fsc and FCS. In that case it may be a good idea to convert the deduplicate function into a common helper (where?) parameterizing the seen dictionary.
• Try to move the code to CompileOps.ParseOneInputFile which seems to be common place to obtain the ParsedInputs both in Deduplicate module names dotnet/fsharp#2728 and this PR. In that case we probably need to make seen a parameter of ParseOneInputFile as this is a module helper and I guess it's not good to make it dependent of a static mutable value.

[forki]

I vote for keeping it as is in both places for now without making it DRY. Tbh I think I also need to fix it in fsi. Will do that in separate pr Am 01.04.2017 13:13 schrieb "Alfonso Garcia-Caro" <notifications@github.com

…

: @vasily-kirichenko <https://github.com/vasily-kirichenko> Thanks for the comment. I assume this also means that IncrementalBuilder.ParseTask won't be accessing seen from a different thread. Now that you say that @forki <https://github.com/forki>, I realize that we may have the opposite problem: fsc doesn't hit the code in this PR. So we have two options: - Keep the fix in the two places so it applies to both fsc and FCS. In that case it may be a good idea to convert the deduplicate function into a common helper (where?) parameterizing the seen dictionary. - Try to move the code to CompileOps.ParseOneInputFile which seems to be common place to obtain the ParsedInputs both in dotnet/fsharp#2728 <dotnet/fsharp#2728> and this PR. In that case we probably need to make seen a parameter of ParseOneInputFile as this is a module helper and I guess it's not good to make it dependent of a static mutable value. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#749 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNMd8GdTE_7YGgIlaehfwb6T0NXAlks5rrjFfgaJpZM4MwO5C> .

[forki]

So @dsyme please merge this one and @alfonsogcnunez please amend this to your VF# PR (so that VS tooling gets it as well). I will take care of fsi.

[alfonsogarciacaro]

I have published a new Fable version with a custom FCS binary and it's working for now. We can put this on hold until thinking a better way to consolidate the fix among FCS, fsc and fsi 👍