Handle serialization of odd float values #1275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately
System.Double.NaN
,System.Double.PositiveInfinity
andSystem.Double.NegativeInfinity
cause invalid JSON to be generated. These seem like special cases that shouldn't happen often but they are not disallowed by the type system.I was using FsCheck to generate
JsonValue
instances and I noticed an array containingNaN
which causes JSON parsers to error.This change attempts to mimic the decisions already made in JavaScript, e.g.