Fix StackOverflow exception caused by many ampersand and semicolins i… #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@berickson1 Could you add a test case for this? |
|
To do this I'm going to have to enable tail calls in FSharp.Data debug builds - since tail recursion is what prevents this from crashing. I'll update the PR to include this and let you decide if it's desirable or not |
…n attribute values The original attributeValueCharRef function took a continutation parameter that was always a reference back to the caller. Splitting this into two functions (one where each case is handled) removes the non-tail recursive call. This can occur if an html attribute has a bunch of encoded html inside of it
dsyme
approved these changes
Sep 24, 2019
|
Thanks for adding the test case!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n attribute values
The original attributeValueCharRef function took a continutation parameter that was always a reference back to the caller. Splitting this into two functions (one where each case is handled) removes the non-tail recursive call.
This can occur if an html attribute has a bunch of encoded html inside of it