Tags delimited by colon, not @ ?

[adibsaad]

Hi,

In this line

go-dockerclient/image.go

Line 322 in 91f5ca9

if opts.Tag == "" && strings.Contains(opts.Repository, "@") {

I noticed you are extracting the tag by splitting on the @ character, but aren't tags separated by : e.g. ubuntu:latest or am I missing something here?

I found this issue when I was debugging another issue related to moby/moby#42053

Thanks.

[fsouza]

Hi @adibsaad, tags are delimited by :, and digests are delimited by @. The Docker API overloads the "tag" parameter with both the tag and the digest: https://docs.docker.com/engine/api/v1.41/#operation/ImageCreate

[thaJeztah]

Perhaps it would make sense to add an PullImageOptions.All option (similar to api/types/client.go#L252-L254; the All option would skip sending the tag parameter.

go-dockerclient/image.go

Lines 293 to 296 in 91f5ca9

	type PullImageOptions struct {
	Repository string `qs:"fromImage"`
	Tag string
	Platform string `ver:"1.32"`

client.PullImage() could produce an error if neither the All option, nor Tag are set;

go-dockerclient/image.go

Line 313 in 91f5ca9

func (c *Client) PullImage(opts PullImageOptions, auth AuthConfiguration) error {

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[adibsaad]

Thanks @fsouza , I'd forgotten about this.

[fsouza]

@adibsaad me too lol Thank the bot haha