Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on docker is not compatible with freebsd/amd64 #878

Closed
illarion opened this issue Sep 4, 2021 · 5 comments
Closed

Dependency on docker is not compatible with freebsd/amd64 #878

illarion opened this issue Sep 4, 2021 · 5 comments
Labels

Comments

@illarion
Copy link

illarion commented Sep 4, 2021

This specific file is not able to compile:
https://github.com/moby/moby/blob/v20.10.8/pkg/system/mknod.go

GOOS=freebsd GOARCH=amd64 go build 
# github.com/docker/docker/pkg/system
../../go/pkg/mod/github.com/docker/docker@v20.10.8+incompatible/pkg/system/mknod.go:12:19: cannot use dev (type int) as type uint64 in argument to unix.Mknod
@fsouza fsouza added the bug label Sep 7, 2021
@fsouza
Copy link
Owner

fsouza commented Sep 7, 2021

🤔 need to track down how we're getting to that package or if docker is willing to fix it.

@illarion
Copy link
Author

The most frustrating part is that mknod.go is not used by go-dockerclient by design, but there is no way to exclude it

@fsouza
Copy link
Owner

fsouza commented Sep 13, 2021

Yeah I looked into it a bit, it looks like we get it via github.com/docker/docker/pkg/archive.

I opened moby/moby#42849 to see if the folks over there would be open for a PR fixing it on their side. If not, we may need to vendor that package or something like that.

@moonshine-cc
Copy link

moonshine-cc commented Feb 5, 2022

This issue is connected to the problems that I have experienced here.

@fsouza fsouza closed this as completed in 19c1ce8 Feb 10, 2022
@fsouza
Copy link
Owner

fsouza commented Feb 10, 2022

@moonshine-cc I just pushed go-dockerclient@v1.7.8 and that should compile on freebsd now. I also added a job to cross compile in CI, it isn't as good as running the tests in freebsd, but at least we can guarantee no regression. Let me know if you need any info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants