-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The module name change issues #966
Comments
Can you clarify what issues you're facing? When docker renamed the repo to moby, they didn't change the name of the package, which means there's no impact to people importing it. |
For example, my project introduced go-dockerclient and moby as submodules, and now the path to them has changed, but the new path does not contain the original files,
but in fact, the path is
your code distribution.go
if I add the submodule moby, the path doesn't have the file. in fact, its path is |
How are you vendoring the code? Are you using go modules? For context, the repository docker/docker was renamed to moby/moby in 2017. It happened almost 6 years ago, and it shouldn't affect go-dockerclient's ability to import its code. |
Such as this project docker-ipv6nat, now the submodule path is I think this is unreasonable, is there a more perfect solution? |
Oh I see you're using Git submodules for vendoring. I strongly recommend migrating to Go modules, but if you'd like to continue using Git submodules, you should just remember to manually clone it under
This alternative would work too:
You just need to make sure that the path is |
The original project name is https://github.com/docker/docker.
but now the name is https://github.com/moby/moby,
and some project submodules such as: /xxx/vendor/github.com/fsouza/go-dockerclient/distribution.go#L11 it has an old path, how to deal with it?
The text was updated successfully, but these errors were encountered: