Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSBuildHelper BuildWebsite fails with invalid OutDir path #1032

Closed
reidev275 opened this issue Dec 7, 2015 · 1 comment
Closed

MSBuildHelper BuildWebsite fails with invalid OutDir path #1032

reidev275 opened this issue Dec 7, 2015 · 1 comment

Comments

@reidev275
Copy link
Contributor

This happens because of the prefix code in BuildWebsite https://github.com/fsharp/FAKE/blob/master/src/app/FakeLib/MSBuildHelper.fs#L435.

My outputPaths are local file paths like c:\deploys\artifacts so the existing ../ prefix turns my output paths into ../../c:\deploys\artifacts

If I switch the prefix code to check if the path is rooted the build works.

let prefix = if Path.IsPathRooted outputPath
             then ""
             else (String.replicate diff "../")

I may be missing something with the initial intent of the prefix code that would break with this suggested change though.

@forki since you had the initial commit on this line can you help determine whether my suggestion helps or hurts?

@matthid
Copy link
Member

matthid commented May 6, 2017

Seems to be fixed.

@matthid matthid closed this as completed May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants