You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Functions in the Fake.AssemblyInfo module don't work as expected because they don't find all attributes in an AssemblyInfo.vb file with uppercased <Assembly: ...> attributes. This is unhelpful since Visual Studio uppercases the assembly: part by default. The problem seems to be that the regex (regexAttrNameValueVb) for matching the assembly attributes is used in a case-sensitive way.
Repro steps
In Visual Studio, enable Extras -> Options -> Text Editor -> Basic -> Advanced -> "Pretty listing (reformatting) of code"
Create an AssemblyInfo.vb file in a VB.NET project and edit the versions in the file for example
Use the GetAttributes function on the file to extract all attributes
Expected behavior
GetAttributes should return a sequence containing the attributes in the AssemblyInfo.vb file
Actual behavior
GetAttributes returns an empty sequence
Known workarounds
Disable the aforementioned option in Visual Studio and manually lowercase the <Assembly: ...> to <assembly: ...>.
Related information
Observed on FAKE version 4.26.0.
Problem still exists in the source for version 4.28.0
The text was updated successfully, but these errors were encountered:
If someone told me how to fix it, I'd happily provide a pull request. I'm not sure, however, what would be the best solution to fix the issue. Do you think that matching the regexes case-insensitively in general would be acceptable?
Description
Functions in the Fake.AssemblyInfo module don't work as expected because they don't find all attributes in an AssemblyInfo.vb file with uppercased
<Assembly: ...>
attributes. This is unhelpful since Visual Studio uppercases theassembly:
part by default. The problem seems to be that the regex (regexAttrNameValueVb
) for matching the assembly attributes is used in a case-sensitive way.Repro steps
AssemblyInfo.vb
file in a VB.NET project and edit the versions in the file for exampleGetAttributes
function on the file to extract all attributesExpected behavior
GetAttributes
should return a sequence containing the attributes in theAssemblyInfo.vb
fileActual behavior
GetAttributes
returns an empty sequenceKnown workarounds
Disable the aforementioned option in Visual Studio and manually lowercase the
<Assembly: ...>
to<assembly: ...>
.Related information
The text was updated successfully, but these errors were encountered: