Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHubCI: stop restricting build+test jobs to release/next branch #2673

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

knocte
Copy link
Contributor

@knocte knocte commented May 6, 2022

It is better to let contributors to FAKE run their proposed changes in GitHubCI before they propose a PR. (Without this, they wouldn't know if their changes break tests until they propose a PR.)

@mclark1129
Copy link
Contributor

Just a note here, you can certainly run the workflows on your own fork if needed. That was how I managed to get around waiting on an approval for every change I made. mclark1129#3

@knocte
Copy link
Contributor Author

knocte commented Jun 6, 2022

@mclark1129 the branch you used for your PR was called release/next, that's why the workflows ran in your fork.

But the typical thing a contributor does after forking a project is creating a branch with a name that represents the thing they will work on, not having to stick to the same branch name as the original project (this way they can work on different things too and open more than 1 PR).

@yazeedobaid ping?

@yazeedobaid
Copy link
Collaborator

Hi thanks for the PR
Could you please rebase your branch from release/next? Now that the build has been fixed.

It is better to let contributors to FAKE run their proposed changes
in GitHubCI before they propose a PR. (Without this, they wouldn't know
if their changes break tests until they propose a PR.)
@knocte knocte force-pushed the liberateGithubActions branch from 5bdb10f to 3f6fd95 Compare July 16, 2022 11:15
@knocte
Copy link
Contributor Author

knocte commented Jul 16, 2022

Could you please rebase your branch from release/next?

Done.

Copy link
Collaborator

@yazeedobaid yazeedobaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@yazeedobaid yazeedobaid merged commit 158b635 into fsprojects:release/next Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants