Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paket pack failes if AssemblyName is empty and template type is project. #1234

Closed
trondd opened this issue Nov 17, 2015 · 6 comments
Closed
Labels

Comments

@trondd
Copy link
Contributor

trondd commented Nov 17, 2015

paket pack failes if AssemblyName is empty and template type is file. It complains that the file can't be found, but I think it would be more useful to point to the root issue in the GetAssemblyName function in ProjectFile.fs

Paket version is 2.15.7.0

@forki
Copy link
Member

forki commented Nov 17, 2015

do you have a csproj and template file for me?

@trondd
Copy link
Contributor Author

trondd commented Nov 17, 2015

It is part of internal source code, but I'll prepare an example. Stay tuned.

@trondd
Copy link
Contributor Author

trondd commented Nov 17, 2015

See https://github.com/trondd/PaketIssue1234

paket pack output temp -v

Note that I've manually cleared the AssemblyName in the Project file.

@forki
Copy link
Member

forki commented Nov 17, 2015

what output would you expect? And why is the AssemblyName empty in the first place? Does it use a default?

@forki forki added the bug label Nov 17, 2015
@forki
Copy link
Member

forki commented Nov 17, 2015

ok I can reproduce.

    Ein Teil des Pfades "C:\Users\Steffen\AppData\Local\NCrunch\4112\7\integrationtests\scenarios\i001234-missing-assemblyname\temp\PaketBug\bin\Release\.dll" konnte nicht gefunden werden.

which is your filenotfoundexception. Question is: can we improve the GetAssemblyName function? Can we use the CsProj name in this case!?

@forki forki closed this as completed in 4999ab6 Nov 17, 2015
@trondd
Copy link
Contributor Author

trondd commented Nov 17, 2015

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants