Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paket update changes <Paket>False</Paket> entries #679

Closed
matthid opened this issue Mar 5, 2015 · 3 comments
Closed

paket update changes <Paket>False</Paket> entries #679

matthid opened this issue Mar 5, 2015 · 3 comments
Labels

Comments

@matthid
Copy link
Member

matthid commented Mar 5, 2015

I have this diff after running paket update:

--- a/src/source/Yaaf.AdvancedBuilding/Yaaf.AdvancedBuilding.fsproj
+++ b/src/source/Yaaf.AdvancedBuilding/Yaaf.AdvancedBuilding.fsproj
@@ -194,21 +194,12 @@
     </When>
   </Choose>
   <Choose>
-    <When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v4.0')">
+    <When Condition="($(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v4.0' Or $(TargetFrameworkVersion) == 'v4.5' Or $(TargetFram
       <ItemGroup>
         <Reference Include="System.Web.Razor">
           <HintPath>..\..\..\packages\Microsoft.AspNet.Razor\lib\net40\System.Web.Razor.dll</HintPath>
           <Private>True</Private>
-          <Paket>False</Paket>
-        </Reference>
-      </ItemGroup>
-    </When>
-    <When Condition="($(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v4.5' Or $(TargetFrameworkVersion) == 'v4.5.1' Or $(TargetFr
-      <ItemGroup>
-        <Reference Include="System.Web.Razor">
-          <HintPath>..\..\..\packages\.nuget\Microsoft.AspNet.Razor.3.2.2\lib\net45\System.Web.Razor.dll</HintPath>
-          <Private>True</Private>
-          <Paket>False</Paket>
+          <Paket>True</Paket>
         </Reference>
       </ItemGroup>
     </When>

Isn't paket supposed to leave entries alone that I manually switched to <Paket>False</Paket>?

@forki
Copy link
Member

forki commented Mar 5, 2015

Mhm. Actually currently it works only if you remove the the tag. But I think we should change it to under false as well

@matthid
Copy link
Member Author

matthid commented Mar 5, 2015

Ah okey, I thought the difference was that with False would be respected by --hard but I was wrong, so I will just remove it for now, thanks for the quick response!

@forki
Copy link
Member

forki commented Mar 5, 2015

Yep. I apologize for the confusion, but we didn't find a different way to flag our installs. But I totally agree: the true suggests that one can change it to false.

@forki forki closed this as completed in 598a6cb Mar 11, 2015
@forki forki added the bug label Mar 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants