Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake.Globbing.isMatch does not work as expected #884

Closed
devboy opened this issue Jun 20, 2015 · 3 comments
Closed

Fake.Globbing.isMatch does not work as expected #884

devboy opened this issue Jun 20, 2015 · 3 comments
Labels

Comments

@devboy
Copy link
Contributor

devboy commented Jun 20, 2015

Ran into this issue during implementation of #880.

Doing this on fsi with Fake.Globbing opened:

> isMatch "/some/random/path/**/Properties/*" 
          "/some/random/path/somewhere/Properties/AssemblyInfo.cs";;
val it : bool = false
> isMatch "/some/random/path/**/Properties/*.*" 
          "/some/random/path/somewhere/Properties/AssemblyInfo.cs";;
val it : bool = true

I'd expect both to be true.

@forki
Copy link
Member

forki commented Jun 23, 2015

This needs to be fixed in FAKE.
/cc @voiceofwisdom could you please take a look? Thanks.

@xavierzwirtz
Copy link
Contributor

Fixed in fsprojects/FAKE#836

@devboy
Copy link
Contributor Author

devboy commented Jun 23, 2015

Awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants