Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pack command doesn't escape filenames correctly #959

Closed
jamescrowley opened this issue Aug 4, 2015 · 1 comment
Closed

Pack command doesn't escape filenames correctly #959

jamescrowley opened this issue Aug 4, 2015 · 1 comment
Labels
bug needs-repro up-for-grabs

Comments

@jamescrowley
Copy link

I think we've identified an issue with the Pack step in Paket, whereby it escapes spaces in folder names correctly, but not file names:

Paket/src/Paket.Core/NupkgWriter.fs

Line 261 in 68614ba

let path = Path.Combine(target,fi.Name)

Pull request to follow. Let me know if I'm mistaken!
@forki
Copy link
Member

forki commented Aug 4, 2015

You are probably right.

@will14smith will14smith mentioned this issue Aug 5, 2015
Merged
@forki forki closed this as completed Aug 5, 2015
@jamescrowley jamescrowley mentioned this issue Aug 12, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs-repro up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@forki @jamescrowley