Inline anonymous record type declarations do not respect MultilineBlockBracketsOnSameColumn setting

[isaacabraham]

Issue created from fantomas-online

Code

type Foo =
    {
        Bar : {| X : string; Y : int; A : string; B : string |}
        Baz : int
        Blip : string
    }

Result

type Foo =
    {
        Bar: {| X: string
                Y: int
                A: string
                B: string |}
        Baz: int
        Blip: string
    }

Problem description

I would expect the above code to be formatted as follows:

type Foo =
    {
        Bar:
            {|
                X: string
                Y: int
                A: string
                B: string
            |}
        Baz: int
        Blip: string
    }

Extra information

• The formatted result breaks my code.
• The formatted result gives compiler warnings.
• I or my company would be willing to help fix this.

Options

Fantomas master branch at 2022-08-06T07:12:17Z - c1d5250

    { config with
                MultilineBlockBracketsOnSameColumn = true }

_{Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?}

[nojaf]

Hello, I believe this is a duplicate of #1167.
SynType.AnonRecd would need an alternative path based on the setting.

Around

fantomas/src/Fantomas.Core/CodePrinter.fs

Lines 3863 to 3878 in c1d5250

	| TAnonRecord (isStruct, fields) ->
	let smallExpression =
	ifElse isStruct !- "struct " sepNone
	+> sepOpenAnonRecd
	+> col sepSemi fields (genAnonRecordFieldType astContext)
	+> sepCloseAnonRecd
	let longExpression =
	ifElse isStruct !- "struct " sepNone
	+> sepOpenAnonRecd
	+> atCurrentColumn (col sepNln fields (genAnonRecordFieldType astContext))
	+> sepCloseAnonRecd
	fun (ctx: Context) ->
	let size = getRecordSize ctx fields
	isSmallExpression size smallExpression longExpression ctx

longExpression should be something similar to

fantomas/src/Fantomas.Core/CodePrinter.fs

Lines 1086 to 1089 in c1d5250

	let longExpression =
	ifAlignBrackets
	(genMultilineAnonRecordAlignBrackets isStruct fields copyInfo astContext)
	(genMultilineAnonRecord isStruct fields copyInfo astContext)

Note that you cannot just re-use the function because the AST is different.
You would need to create genMultilineAnonRecordType and genMultilineAnonRecordTypeAlignBrackets accordingly. Unit tests can be placed in MultilineBlockBracketsOnSameColumnRecordTests.fs.

Are you interested in submitting a PR for this?

[isaacabraham]

Sorry, yes. Closing as a duplicate.