Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional constructor arguments are lost #2718

Closed
1 of 3 tasks
nojaf opened this issue Jan 16, 2023 · 0 comments · Fixed by #2719 or #2720
Closed
1 of 3 tasks

Optional constructor arguments are lost #2718

nojaf opened this issue Jan 16, 2023 · 0 comments · Fixed by #2719 or #2720
Assignees

Comments

@nojaf
Copy link
Contributor

nojaf commented Jan 16, 2023

Issue created from fantomas-online

Code

type CsvFile
    private
    (
        readerFunc: Func<TextReader>,
        [<Optional>] ?separators,
        [<Optional>] ?quote,
        [<Optional>] ?hasHeaders,
        [<Optional>] ?ignoreErrors,
        [<Optional>] ?skipRows
    ) as this =
    inherit CsvFile<CsvRow>
        (
            Func<_, _, _>(fun this columns -> CsvRow(this :?> CsvFile, columns)),
            Func<_, _>(fun row -> row.Columns),
            readerFunc,
            defaultArg separators "",
            defaultArg quote '"',
            defaultArg hasHeaders true,
            defaultArg ignoreErrors false,
            defaultArg skipRows 0
        )

Result

type CsvFile private (readerFunc: Func<TextReader>) as this =
    inherit
        CsvFile<CsvRow>(
            Func<_, _, _>(fun this columns -> CsvRow(this :?> CsvFile, columns)),
            Func<_, _>(fun row -> row.Columns),
            readerFunc,
            defaultArg separators "",
            defaultArg quote '"',
            defaultArg hasHeaders true,
            defaultArg ignoreErrors false,
            defaultArg skipRows 0
        )

Problem description

Most likely a problem in ASTTransformat when constructing simplePats.

Extra information

  • The formatted result breaks my code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas main branch at 2023-01-14T10:13:32Z - 5336c50

Default Fantomas configuration

Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant