Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we have a Rotor3::into_euler_angles()? #44

Open
Gonkalbell opened this issue Jun 6, 2020 · 5 comments
Open

Could we have a Rotor3::into_euler_angles()? #44

Gonkalbell opened this issue Jun 6, 2020 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Gonkalbell
Copy link

There's currently a Rotor3::from_euler_angles, but also having a Rotor3::into_euler_angles() would be convenient. I'm still not too familiar with the differences between quaternions and rotors, or if there is much of a difference, so I'm not quite sure how to implement it myself.

@fu5ha
Copy link
Owner

fu5ha commented Jun 25, 2020

Good idea 👍

Ultimately, Rotor3s are isomorphic to quaternions, so the implementation of operations like this is very similar but not exactly the same.

@fu5ha fu5ha added the enhancement New feature or request label Jun 25, 2020
@fu5ha fu5ha added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 28, 2020
@austinliew
Copy link
Contributor

I intend on doing this, but it will rely on Lokathor/wide#82 getting merged.

@fu5ha
Copy link
Owner

fu5ha commented May 21, 2021

Hey @austinliew just a friendly ping to see if you still wanted to do this? I know it's been a while so if you're no longer interested, no worries at all :)

@austinliew
Copy link
Contributor

A while ago I tried messing around with the related equations to figure something out but ended up getting busy with work, so I probably won't be able to get around to this any time soon. I probably won't be able to get around to it any time soon. Sorry about that!

@fu5ha
Copy link
Owner

fu5ha commented May 21, 2021

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants