-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight Samples not aligned to base waveform #101
Comments
I've noticed this as well. Looking through the code I see layoutsubviews has a few lines that doesn't seem to calculate the correct values:
Calculating
The image is still offset a little. But the highlights works correctly with that. |
@ogrydziak I've fixed it in #107 |
Thank you for sharing. I agree that this is broken now. I have tried #107 but it is not fixing the issue for me. |
I believe this is fixed now thanks to @reedom. Also released to CocoaPods and through Carthage today. |
Defined
@IBOutlet weak var grabberContainer_view: FDWaveformView!
In viewdidload
I have the following code attached to a button
http://imgur.com/WCUcETd
What happening in that pic is the full waveform in the light grey, and the result from setting highlightSamples is overlaid in the middle. To me, it looks like the overlay is an incorrect chunk of the waveform (notice that it doesn’t line up). In this SS, I had changed the colors but I just reverted it to the original to make sure I didn’t muss something up inadvertently. Also, I would just be not using this correctly, so I wouldn’t rule that out.
When I changed it to alter the bounds in the setter for highlightedSamples, everything lined up, but then I couldn’t rotate the screen properly.
This may or may not illustrate it better (attached image).
The text was updated successfully, but these errors were encountered: