Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestBrokenTLS_ClientHasExpiredCert fail with golang-1.21 #405

Closed
mikelolasagasti opened this issue Aug 1, 2023 · 2 comments · Fixed by #408
Closed

TestBrokenTLS_ClientHasExpiredCert fail with golang-1.21 #405

mikelolasagasti opened this issue Aug 1, 2023 · 2 comments · Fixed by #408

Comments

@mikelolasagasti
Copy link

Building grpcurl 1.8.7 with golang-1.21 for Fedora Rawhide fails in the following test:

--- FAIL: TestBrokenTLS_ClientHasExpiredCert (0.01s)
    tls_settings_test.go:217: expecting TLS certificate error, got: remote error: tls: expired certificate
@MyUmmaGumma
Copy link

Similar error on Manjaro Linux, grpcurl 1.8.7-1 - installing via makepkg
Is the fix to call ClientTransportCredentials(...,..., "internal/testing/tls/wrong-client.crt",...) instead of calling it with internal/testing/tls/expired.crt in tls_settings_test.go?

@dragonsinth
Copy link
Member

#408

@dragonsinth dragonsinth mentioned this issue Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run tests on Go 1.21 sigv/grpcurl
3 participants
@mikelolasagasti @dragonsinth @MyUmmaGumma