Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mute file duplicated during training #8

Open
SayanoAI opened this issue Jun 6, 2024 · 4 comments
Open

mute file duplicated during training #8

SayanoAI opened this issue Jun 6, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@SayanoAI
Copy link

SayanoAI commented Jun 6, 2024

what's the rationale for duplicating the mute files during training?

image

Why does including it just once not work?

@alexlnkp
Copy link
Contributor

alexlnkp commented Jun 7, 2024

if_f0_3 is always true, because you can't extract without a f0 method, idk why that is there

(unrelated to OP's issue) honestly i'm extremely tired of all the weird names for vars and functions that are in RVC.
i'll start working on renaming all of the vars to be something that is easier to understand

@fumiama
Copy link
Owner

fumiama commented Jun 7, 2024

i'll start working on renaming all of the vars to be something that is easier to understand

Thanks but maybe you can start it later to aviod code conflicts because I'm changing the whole code structure recently.

As for the main topic of this issue, I will remove all unnecessary vars in train later. Now I am just working on the infer part.

@fumiama fumiama added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Jun 7, 2024
@SayanoAI
Copy link
Author

SayanoAI commented Jun 7, 2024

Thanks but maybe you can start it later to aviod code conflicts because I'm changing the whole code structure recently.

As for the main topic of this issue, I will remove all unnecessary vars in train later. Now I am just working on the infer part.

I'd recommend structuring the RVC code as a pypi package and build the gui on top of that. This will make it easier for people to create colabs and whatnot.

@fumiama
Copy link
Owner

fumiama commented Jun 7, 2024

I'd recommend structuring the RVC code as a pypi package

Yes. See the progress at https://github.com/RVC-Project/Retrieval-based-Voice-Conversion .

But now, I'm just letting the RVC code seeing more like a package so that we can migrate to package version easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants