Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] accept a function on filter param of discover() method #2

Closed
dayflower opened this issue Jul 31, 2018 · 3 comments
Closed

Comments

@dayflower
Copy link

I would appreciate it if this product could also accept a function on filter param of discover() method.

Like this:

mDnsSd.discover({
  name: '_googlecast._tcp.local',
  filter: (device) => {
    return device['modelName'] && device['modelName'] === 'Google Home Mini'
        && device['familyName'] && device['familyName'] === 'Living Room'
  }
});
@futomi
Copy link
Owner

futomi commented Aug 2, 2018

Thank you so much for your feedback. That's a nice idea! I'll implement the filter parameter to the discover() method soon. Give me some time.

@futomi
Copy link
Owner

futomi commented Aug 2, 2018

I implemented the function-based filter in the discover() method. Try the latest version.

@dayflower
Copy link
Author

Great!

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants