Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use INVALID (FE) instead of REVERT (FD) #6

Open
luzianscherrer opened this issue Aug 26, 2022 · 3 comments
Open

Use INVALID (FE) instead of REVERT (FD) #6

luzianscherrer opened this issue Aug 26, 2022 · 3 comments

Comments

@luzianscherrer
Copy link

Wouldn't it be cleaner to use INVALID (FD) instead of REVERT (FD) for the dead ends as REVERT requires two items on the stack and always results in a stack underflow otherwise?

Anyhow, thanks for those great little games! I did enjoy them a lot.

@fvictorio
Copy link
Owner

Oh damn, good call, I didn't realize that that was happening. I'll change it, thanks for the tip!

@luzianscherrer
Copy link
Author

Also on a side note, I would suggest modifying puzzle 10 a little because as the modulo operation at position 0E is required to result in 0 one can just omit the calldata completely in order to pass which makes it a little too easy.

A slightly modified version keeping the spirit of the original would be: 38349011600857FD5B3661000390063460090157FDFDFDFD5B00

@jeasonstudio
Copy link

I find the most intriguing aspect to be the discussion on the utilization of create/extcodesize/call. These puzzles necessitate comprehension of the bytecode that is required to create a contract and return its contents, which proves beneficial for novices.
The significance of the mod opcode in Puzzle 10 has become less important. @luzianscherrer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants