From 7bd0ab63a8441c3f3d7f495d09ed2bed38762874 Mon Sep 17 00:00:00 2001 From: Googler Date: Mon, 28 Nov 2022 06:12:40 -0800 Subject: [PATCH] Default --incompatible_strict_conflict_checks to true. The downstream pipeline indicates that this is safe to flip: https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1346 Fixes #16729. RELNOTES[INC]: `--incompatible_strict_conflict_checks` is flipped to true. See https://github.com/bazelbuild/bazel/issues/16729 for details. PiperOrigin-RevId: 491324038 Change-Id: Iea8951867fa20f2aa1a67bf3ba3c86c26e4292de --- .../google/devtools/build/lib/analysis/AnalysisOptions.java | 2 +- .../build/lib/remote/BuildWithoutTheBytesIntegrationTest.java | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/google/devtools/build/lib/analysis/AnalysisOptions.java b/src/main/java/com/google/devtools/build/lib/analysis/AnalysisOptions.java index f7cc3967b0b436..b8ca3c08405d99 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/AnalysisOptions.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/AnalysisOptions.java @@ -93,7 +93,7 @@ public class AnalysisOptions extends OptionsBase { @Option( name = "incompatible_strict_conflict_checks", oldName = "experimental_strict_conflict_checks", - defaultValue = "false", + defaultValue = "true", documentationCategory = OptionDocumentationCategory.UNDOCUMENTED, metadataTags = OptionMetadataTag.INCOMPATIBLE_CHANGE, effectTags = {OptionEffectTag.BAZEL_INTERNAL_CONFIGURATION}, diff --git a/src/test/java/com/google/devtools/build/lib/remote/BuildWithoutTheBytesIntegrationTest.java b/src/test/java/com/google/devtools/build/lib/remote/BuildWithoutTheBytesIntegrationTest.java index 70e138cbc34ed3..920dd8870308f8 100644 --- a/src/test/java/com/google/devtools/build/lib/remote/BuildWithoutTheBytesIntegrationTest.java +++ b/src/test/java/com/google/devtools/build/lib/remote/BuildWithoutTheBytesIntegrationTest.java @@ -312,6 +312,8 @@ public void symlinkToDirectory() throws Exception { @Test public void symlinkToNestedFile() throws Exception { + addOptions("--noincompatible_strict_conflict_checks"); + write( "a/defs.bzl", "def _impl(ctx):", @@ -364,6 +366,8 @@ public void symlinkToNestedFile() throws Exception { @Test public void symlinkToNestedDirectory() throws Exception { + addOptions("--noincompatible_strict_conflict_checks"); + write( "a/defs.bzl", "def _impl(ctx):",