Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider providing a non-distroless Docker image #109

Closed
SoerenHenning opened this issue Jan 14, 2022 · 2 comments · Fixed by #115
Closed

Consider providing a non-distroless Docker image #109

SoerenHenning opened this issue Jan 14, 2022 · 2 comments · Fixed by #115
Assignees

Comments

@SoerenHenning
Copy link

With #108 automatic builds of a Docker image were introduced. The provided Docker image is a distroless one, which should be absolutely fine (and probably the best option) for running crdoc in most situations.

Unfortunately, GitLab CI/CD requires images that contain a shell. I guess similar requirements also exist in other CI/CD tools.

Hence I'm asking whether a second image could be provided which builds upon alpine or similar. I looked at the GoReleaser docs and it seems to be possible to define multiple image with different Dockerfiles.

@roee88
Copy link
Contributor

roee88 commented Jan 15, 2022

No need for multiple images, changing the base image in the current Dockerfile should be enough. The preference would be to switch to ubi8-minimal. Is there any way for you to verify if that ubi8 works with gitlab beforehand?

@roee88 roee88 self-assigned this Jan 15, 2022
@SoerenHenning
Copy link
Author

Okay, great. I thought there might be some reasons why you would prefer a distroless image. I just did some small tests with registry.access.redhat.com/ubi8-minimal:latest and it seems to work perfectly fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants