Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Gzipping text providers #1802

Open
exussum12 opened this issue Oct 3, 2019 · 3 comments
Open

Gzipping text providers #1802

exussum12 opened this issue Oct 3, 2019 · 3 comments

Comments

@exussum12
Copy link

Looking at the Text files they are 6.8MB. With gzip these could be 2.3MB a saving of 4.5MB.

This would require a minor rewrite of all of the text files and rely on gzencode and gzdecode.

Happy to do this just checking this would be a change which would be accepted ?
Installs over past 30 days taken from packagist is 2,733,223 which equates to 13TB of extra hard drive space taken up by this just in the last 30 days . Bandwidth would drop less so (a little under 0.1mb from a quick test) but even that would add up given the popularity,

Let me know your thoughts

Thanks

@pimjansen
Copy link
Contributor

@exussum12 this would mean we have to update all providers right since we need to move the actual content in a seperate file to gzip?

@exussum12
Copy link
Author

exussum12 commented Oct 4, 2019

Either a seperate file or just replace the content with gzip in the heredocs. Happy to do either way.if it's in the heredocs would just need to call a function on the content. It would be the smaller code change but the class would be unreadable

@pimjansen
Copy link
Contributor

@exussum12 i like the idea however we are planning in releasing the latest 1.x version of Faker and after that start with 2.0. So i would like to drag this in there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants