Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Redux #38

Closed
gaearon opened this issue Jul 20, 2015 · 7 comments
Closed

Port to Redux #38

gaearon opened this issue Jul 20, 2015 · 7 comments

Comments

@gaearon
Copy link
Owner

gaearon commented Jul 20, 2015

I intend to port this example to Redux.

I'm not doing that to promote my library, but because reusable store utilities (like pagination) are way easier to implement as pure functions. What I have right now in PaginatedStoreUtils is a mess, and will be much more sensible with Redux approach.

However, I understand that not everybody will be happy with this change, as Redux is not exactly Flux. I think it solves the same problems better than Flux, but that's my opinion and some may not share it.

Therefore I ask what you think:

  • Should I rename the repository to reflect that it's a Redux example now?
  • Should I keep the old vanilla Flux code in a branch?

To clarify again:

  • I intend to keep it minimal, just like the current repo, and handle the same cases: pagination, “load more”, spinners.
  • The “content stores” / “list stores” distinction will be even clearer with reusable reducers.
  • This is not an artificial effort to port for the sake of porting. The code will be clearer after porting to Redux, and the idioms currently used by the code will be more apparent and natural.

Thoughts?

@felipeleusin
Copy link

Imho rename and kee pthe flux in an old branch and keep a link in the readme.... Between redux and react-router 1.0 there is going to be A LOT of changes. Also, thanks for all the work you've been doing with redux lately!

@ghost
Copy link

ghost commented Jul 20, 2015

like @felipeleusin has said it, rename it and keep the old version. maybe as branch or maybe even only as link to current revision.

@davidwatkins73
Copy link

agree with @felipeleusin. V. interested in seeing this port.

@i4got10
Copy link

i4got10 commented Jul 22, 2015

It might be better to make a new repository redux-react-router-example

@idolize
Copy link

idolize commented Aug 6, 2015

Awesome, can't wait for this!

@gaearon
Copy link
Owner Author

gaearon commented Aug 11, 2015

The port will be part of the official Redux repo.
PR: reduxjs/redux#460

@gaearon
Copy link
Owner Author

gaearon commented Aug 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants