Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Hot Loader 2 Umbrella #186

Closed
5 of 13 tasks
gaearon opened this issue Aug 28, 2015 · 5 comments
Closed
5 of 13 tasks

React Hot Loader 2 Umbrella #186

gaearon opened this issue Aug 28, 2015 · 5 comments

Comments

@gaearon
Copy link
Owner

gaearon commented Aug 28, 2015

  • Use React Proxy as new internal engine
  • Support hot-reloading getters, statics (via React Proxy)
  • Remove dependency on react/lib/ReactMount
  • Recover from module definition level errors
  • Recover from file not found errors
  • Show syntax errors in an overlay (maybe even switch to webpack-hot-middleware by @glenjamin)
  • Recommend using babel-plugin-wrap-react-components for a better experience:
    • Hot-reload non-exported classes
    • Hot-reload classes that are wrapped in HOCs
    • Take another look at hot reloading ES7 properties
    • Make it easy to handle render() errors (Catch errors inside render #164)
  • Keep the old export rewriting for CoffeeScript and other compile-to-JS users?
  • Make sure stuff like Omniscient still works
@glenjamin
Copy link

It seeks like perhaps these

Show syntax errors in an overlay (maybe even switch to webpack-hot-middleware by @glenjamin)
Recover from module definition level errors
Recover from file not found errors

Should be out of scope for RHL, as they're not react specific? Maybe just include suggested approaches in docs?

Afaik, hot-middleware handles all 3 cases currently.

@STRML
Copy link

STRML commented Aug 28, 2015

Depending on a shared module that handles syntax errors/ENOENT sounds like the right approach to me. 👍

@gaearon
Copy link
Owner Author

gaearon commented Aug 28, 2015

Maybe just include suggested approaches in docs?

Yes, that's what I meant. I mean not just the code, but also the boilerplate, Getting Started guide, etc.

@gaearon
Copy link
Owner Author

gaearon commented Aug 28, 2015

@glenjamin

Though as you probably saw,

Recover from module definition level errors

and

Recover from file not found errors

(when NoErrorsPlugin isn't enabled)

were actually broken until #187 so that counts.

@gaearon
Copy link
Owner Author

gaearon commented Apr 17, 2016

Meh, this is very old.

@gaearon gaearon closed this as completed Apr 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants