-
Notifications
You must be signed in to change notification settings - Fork 430
hot reloading not happening for child [dumb] components #66
Comments
Did you resolve this? I think I'm running into the same issue and I'm curious if you have a solution. Thanks. |
I'm running into the same issue. I'm using react-redux and connected components are being refreshed correctly (sort of, only render changes, not property changes) but child components are being reloaded but not refreshed. Any solution? |
It's impossible to diagnose the issue without a full project reproducing them with exact repro steps. |
agree to @gaearon that .. these issues are project specific and versions we are using for specific packages. For me this got resolved after upgrading to Babel 6 and cleaning up some child components. Please check if its happening for only few child components or all (that was the trick for me) |
Was hoping it was just a configuration change, working on debugging now and creating a sample project. Thanks. |
I've found the problem. If a component is wrapped in a For completeness, here is what I'm seeing: _Connected component:_
_Wrapped component:_
Changing the text It looks like the problem is in
If you comment out the version check, the component will start updating, though it is one update behind for some reason. For example, if you replace |
As I continue to hack away, looks like getting rid of the version check in
However, commenting out the version check messes up all normal updates so that the UI isn't actually usable anymore... |
Repository demonstrating issue is available at https://github.com/bunkat/counter. It is the react-redux counter example with babel6 hot loading and a new connected wrapper component. To reproduce the issue:
The module will be updated via HMR, but the Counter component will not be rendered with the new text. |
I've opened a new issue at reduxjs/react-redux#224 since I think this is a different issue that is expected to work at the moment. |
Good catch, thanks for reporting and providing a full repro. This one is a bug indeed. |
I have container components and child components. Live reloading happens for my any changes in root (container) components but child components changes are not triggering even webpack rebuild.
part of webpack.config.file
.babelrc
The text was updated successfully, but these errors were encountered: