Fix some typos, mostly in comments #513
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagolews
reviewed
Jun 17, 2024
| @@ -214,7 +214,7 @@ const char* ICUError::getICUerrorName(UErrorCode status) | |||
| // case U_FMT_PARSE_ERROR_START: | |||
| // return "Start of format library errors."; | |||
| case U_MULTIPLE_DECIMAL_SEPARATORS: | |||
| // case U_MULTIPLE_DECIMAL_SEPERATORS: | |||
There was a problem hiding this comment.
This should be kept as-is; it was a typo in the ICU4C codebase...
gagolews
reviewed
Jun 17, 2024
| @@ -264,7 +264,7 @@ const char* ICUError::getICUerrorName(UErrorCode status) | |||
| return "UnicodeSet witing an RBBI rule missing a closing ']'."; | |||
| case U_BRK_ASSIGN_ERROR: | |||
| return "Syntax error in RBBI rule assignment statement."; | |||
| case U_BRK_VARIABLE_REDFINITION: | |||
There was a problem hiding this comment.
This should be kept as-is; it was a typo in the ICU4C codebase...
|
All changes look good except for those in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.