fix: make require-exact-type ignore indexers in map types (#354)

gajus · Sep 18, 2018 · 0722187 · 0722187
1 parent 65c9225
commit 0722187
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/rules/requireExactType.js b/src/rules/requireExactType.js
@@ -10,10 +10,10 @@ const create = (context) => {
 
   return {
     TypeAlias (node) {
-      const {id: {name}, right: {type, exact}} = node;
+      const {id: {name}, right: {type, exact, indexers}} = node;
 
       if (type === 'ObjectTypeAnnotation') {
-        if (always && !exact) {
+        if (always && !exact && indexers.length === 0) {
           context.report({
             data: {name},
             message: 'Type identifier \'{{name}}\' must be exact.',

diff --git a/tests/rules/assertions/requireExactType.js b/tests/rules/assertions/requireExactType.js
@@ -69,6 +69,9 @@ export default {
     {
       code: 'type foo = {| bar: string |};'
     },
+    {
+      code: 'type foo = { [key: string]: string };'
+    },
     {
       code: 'type foo = number;'
     },
-Original file line number
+Diff line change
@@ Expand Up / @@ -69,6 +69,9 @@ export default { @@
         {
           code: 'type foo = {| bar: string |};'
         },
+        {
+          code: 'type foo = { [key: string]: string };'
+        },
         {
           code: 'type foo = number;'
         },
@@ Expand Down @@