Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getter and setter for no-dedupe #435

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

SebastienGllmt
Copy link
Contributor

Fix #431

Summary of problem

The following code failed because get occurs twice (it should instead be comparing function names)

export interface Foo {
    get foo(): boolean;
    get bar(): string;
}

root cause: the function call getParameterName(identifierNode, context) did not take into account that get and set tokens may occur before the variable name. This PR fixes this.

@gajus gajus merged commit da05064 into gajus:master Nov 12, 2019
@gajus
Copy link
Owner

gajus commented Nov 12, 2019

🎉 This PR is included in version 4.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getters in interface incorrectly raises flowtype/no-dupe-keys
2 participants