Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixer to invalid file annotation style message #440

Merged
merged 2 commits into from
Jan 11, 2020

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Jan 10, 2020

This helps to make annotation style consistent gradually when touching files.

@joanrodriguez
Copy link

👍🏼

@gajus
Copy link
Owner

gajus commented Jan 11, 2020

It appears that this would break @flow strict

https://flow.org/en/docs/strict/

@TrySound
Copy link
Contributor Author

@gajus How it will break @flow strict? I pass annotationValue not hardcoded string. I added test to make it clear.

@gajus gajus merged commit 97a230b into gajus:master Jan 11, 2020
@gajus
Copy link
Owner

gajus commented Jan 11, 2020

🎉 This PR is included in version 4.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Jan 11, 2020
@TrySound TrySound deleted the fix-invalid-annotation-style branch January 11, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants