Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore newline char in NO_PROXY variable #63

Open
emalysz opened this issue Jun 26, 2023 · 0 comments
Open

Ignore newline char in NO_PROXY variable #63

emalysz opened this issue Jun 26, 2023 · 0 comments

Comments

@emalysz
Copy link

emalysz commented Jun 26, 2023

If the NO_PROXY variable contains a newline at the end /n, isUrlMatchingNoProxy will throw an error:

global-agent/src/utilities/isUrlMatchingNoProxy.ts

Line 17 in f82ad8a

throw new UnexpectedStateError('Invalid NO_PROXY pattern.');

Can we instead ignore this char?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emalysz