fix: alignCenter (#115) #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method for alignCenter is checking to see if halfWidth (rather than width) is even. This worked with the existing test case because the container width given is 6 minus string width (2) is 4. Divide that in half and you have an even number. My test case makes the container width 8. So available width is 6. Divide that in half you get an odd number. So the odd logic triggers padding 3 to the left and 4 to the right. This commit fixes the minor defect.
|
I don't know how to get your build to pass. But you can use the test case as you wish to demonstrate the defect to yourself. |
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method for alignCenter is checking
to see if halfWidth (rather than width)
is even. This worked with the existing test
case because the container width given is 6
minus string width (2) is 4. Divide that in half
and you have an even number.
My test case makes the container width 8.
So available width is 6. Divide that in half
you get an odd number. So the odd logic triggers
padding 3 to the left and 4 to the right.
This commit fixes the minor defect.
Fixes #115