Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on the npm version the tables are broken #95

Closed
Nahasapeemapetilon opened this issue Jun 16, 2019 · 9 comments
Closed

on the npm version the tables are broken #95

Nahasapeemapetilon opened this issue Jun 16, 2019 · 9 comments

Comments

@Nahasapeemapetilon
Copy link

hi i use the npm version but the tables are broken.
the tables look like on the npm page:

https://www.npmjs.com/package/table

image

@gajus gajus added the invalid label Jun 16, 2019
@gajus
Copy link
Owner

gajus commented Jun 16, 2019

Please share the full code to replicate the issue.

@gajus gajus closed this as completed Jun 16, 2019
@Nahasapeemapetilon
Copy link
Author

hi gajus its just the example code from the page
it was a screenshoot from

https://www.npmjs.com/package/table

image
if i use the same code to send a message to telegram

looks like this:

image

but here is the code i try :
`
const {table} = require('table');

let data = [
['0A ', '0B', '0C'],
['1A', '1B', '1C'],
['2A', '2B', '2C']
];
let config = {
columns: {
0: {
alignment: 'left',
minWidth: 3
},
1: {
alignment: 'center',
minWidth: 3
},
2: {
alignment: 'right',
minWidth: 3
}
}
};
let output = table(data,config);
//let output = table(data);
console.log(output);
sendTo('telegram.0', output );`

@gajus gajus reopened this Jun 16, 2019
@gajus gajus closed this as completed in ce2e916 Jun 16, 2019
@gajus
Copy link
Owner

gajus commented Jun 16, 2019

There is no such property minWidth. You should get an error that configuration is invalid. I have updated the invalid documentation example.

@gajus
Copy link
Owner

gajus commented Jun 16, 2019

🎉 This issue has been resolved in version 5.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Jun 16, 2019
@Nahasapeemapetilon
Copy link
Author

thanks for the quick fix but i don't think that was the reason why all sample tables are displayed incorrectly on the npm page. on the github page the sample tables look all correct

@gajus
Copy link
Owner

gajus commented Jun 17, 2019

Screenshot 2019-06-17 at 09 22 50

I am not seeing the issue that you are describing. Seems like you are using custom styles/ cannot load fonts that npmjs.com is using.

@Nahasapeemapetilon
Copy link
Author

hi, i dont have any styles installed.
i try it on two pc with different browsers, maybe its an language setting problem from windows?
i use german settings

image

@gajus
Copy link
Owner

gajus commented Jun 17, 2019

Maybe. In either case, this is npmjs.com issue. There isn't much (to the best of my knowledge) that we could even do about this.

@Nahasapeemapetilon
Copy link
Author

ok thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants