Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Use solc --base-path to project root by default #1315

Closed
mattsse opened this issue May 27, 2022 · 1 comment · Fixed by #1317
Closed

Use solc --base-path to project root by default #1315

mattsse opened this issue May 27, 2022 · 1 comment · Fixed by #1317

Comments

@mattsse
Copy link
Collaborator

mattsse commented May 27, 2022

currently, source files in the compilerinput are canonic, this can cause some issues with metadata/hashes.

in #1307 we already save the artifacts with relative files, this should be obsolete if we set base-path == root and strip the root from all sources

@mattsse mattsse changed the title Use solc --base-path == root by default Use solc --base-path to project root by default May 27, 2022
@mattsse
Copy link
Collaborator Author

mattsse commented May 27, 2022

there's actually no support for setting the basePath in the compilerinput, instead we should be able to get the same behaviour by setting current dir when invoking solc to root and stripping the root from the compilerinput sources

or similar to how remappings are provided in standard-json input mode

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant