Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure reasonable size of Omnipool position #674

Open
mrq1911 opened this issue Sep 20, 2023 · 2 comments
Open

Ensure reasonable size of Omnipool position #674

mrq1911 opened this issue Sep 20, 2023 · 2 comments

Comments

@mrq1911
Copy link
Member

mrq1911 commented Sep 20, 2023

to avoid spam and dust on the chain we should check that you cannot create or update omnipool position so its value is lower than some boud (for example 1000 HDX)

@jak-pan
Copy link
Contributor

jak-pan commented Oct 14, 2023

This is also problematic with LM on top.

@jak-pan
Copy link
Contributor

jak-pan commented May 16, 2024

I think there are 2 issues intertwined.

  1. Storage - We could just charge more for NFT creation and then possibly refund?
  2. Nonsensical computation + LM problems.

We need to make sure that this is not exploitable. If we add deposit for position, we need to make sure the deposit either stays in account locked or is recorded in position or not change the price.

If we add minimal limit it shouldn't change and should be per-asset otherwise you might lock yourself out as we had this problem in the past in XYK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants