Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tb-profiler to 6.4.0 #6543

Merged
merged 6 commits into from
Nov 16, 2024
Merged

Conversation

emarinier
Copy link
Contributor

@emarinier emarinier commented Nov 8, 2024

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

Related to #5139

@emarinier
Copy link
Contributor Author

emarinier commented Nov 8, 2024

Testing error appears to be:

[E::hts_open_format] Failed to open file "vcf/tbprofiler.targets.vcf.gz" : No such file or directory
Failed to read from vcf/tbprofiler.targets.vcf.gz: No such file or directory

and possibly:

[19:57:03] INFO     Running delly                                      bam.py:84
           ERROR    delly: error while loading shared libraries:    utils.py:534
                    libboost_iostreams.so.1.85.0: cannot open                   
                    shared object file: No such file or directory               
                                                                                
           ERROR    Delly failed, skipping                             bam.py:96

The delly-related error doesn't appear when run locally with planemo serve. However, it seems like a similar error has happened before for others with tb-profiler: jodyphelan/TBProfiler#88

@emarinier
Copy link
Contributor Author

emarinier commented Nov 12, 2024

The solution appears to be fixing the version of delly:

<requirements>
    <requirement type="package" version="1.2.6">delly</requirement>
    <requirement type="package" version="@TOOL_VERSION@">tb-profiler</requirement>
</requirements>

See these issues for some more information:

jodyphelan/TBProfiler#393 (comment)
jodyphelan/TBProfiler#371 (comment)

@bgruening
Copy link
Member

@pvanheus do you want to have a look?

@emarinier thanks a lot

</macros>
<xrefs>
<xref type="bio.tools">tb-profiler</xref>
</xrefs>
<requirements>
<requirement type="package" version="1.2.6">delly</requirement>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is true, we should maybe fix the conda package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess then we leave it like it is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming to this late - pathogen-profiler is the underlying tool that tb-profiler uses. It depends on delly 1.2.6. The tb-profiler 4.6.0 in bioconda depends on pathogen-profiler 4.5.0 which has exactly this dependency (delly 1.2.6). I don't understand why an extra requirement is needed in the tool wrapper?

@bgruening bgruening merged commit fe5de3e into galaxyproject:main Nov 16, 2024
11 checks passed
@bgruening
Copy link
Member

Thanks @emarinier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants