-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating tb-profiler to 6.4.0 #6543
Conversation
Testing error appears to be:
and possibly:
The delly-related error doesn't appear when run locally with |
The solution appears to be fixing the version of delly:
See these issues for some more information: jodyphelan/TBProfiler#393 (comment) |
@pvanheus do you want to have a look? @emarinier thanks a lot |
</macros> | ||
<xrefs> | ||
<xref type="bio.tools">tb-profiler</xref> | ||
</xrefs> | ||
<requirements> | ||
<requirement type="package" version="1.2.6">delly</requirement> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is true, we should maybe fix the conda package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh delly is not even a dependency of tb-profiler. https://github.com/bioconda/bioconda-recipes/blob/master/recipes/tb-profiler/meta.yaml
It is a dependency of https://github.com/bioconda/bioconda-recipes/blob/master/recipes/pathogen-profiler/meta.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess then we leave it like it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming to this late - pathogen-profiler is the underlying tool that tb-profiler uses. It depends on delly 1.2.6. The tb-profiler 4.6.0 in bioconda depends on pathogen-profiler 4.5.0 which has exactly this dependency (delly 1.2.6). I don't understand why an extra requirement is needed in the tool wrapper?
Thanks @emarinier |
FOR CONTRIBUTOR:
Related to #5139