0.13: [Bug]: Deploy cached even though there were changes

[stefreak]

Garden Bonsai (0.13) Bug

Current Behavior

First deploy (as expected):

ℹ deploy.postgres      → missing
ℹ deploy.postgres      → Deploying version v-5f8da6486d...

Second deploy (as expected):

ℹ deploy.postgres      → Already deployed

Third deploy with changed password (unexpected!):

ℹ deploy.postgres      → Already deployed

Expected behavior

I expect the postgres module to calculate a different version hash in the third deploy, because the postgres password changed.

Reproducible example

It happens both with kubernetes modules and native action kinds

• Check out the kubernetes-module example from the 0.12 branch
• Alternatively, check out the the kubernetes-deploy example from the main branch

1. Run garden deploy postgres
2. Run garden deploy postgres
3. Run garden deploy postgres --var postgres-password=$(echo somethingelse | base64)

In step three, it is not important that the manifest changes due to the variable parameter. It also reproduces this bug when changing the value of the postgres-password variable in garden.yml.

It even reproduces when simply changing the manifest directly in postgres/garden.yml

Workaround

Downgrade to Garden 0.13.6

Suggested solution(s)

I don't know

Additional context

This is a regression that has been introduced in 0.13.7.
I suspect it might have been introduced in the bigger changes around https://github.com/garden-io/garden/pull/4516/files

@twelvemo and me discovered this one because internal deploy pipelines stopped working.

Your environment

• OS: macOS
• How I'm running Kubernetes: Docker Desktop

garden version 0.13.7

[stefreak]

Confirmed with @vvagaytsev that this regression has been introduced in #4516

Opened #4812 with a revert

TODO: this needs an integration test

[stefreak]

If we find a fix really quickly we can also skip reverting of course 👍