Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sync): deprecate non-interactive sync start and stop commands #5747

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

vvagaytsev
Copy link
Collaborator

@vvagaytsev vvagaytsev commented Feb 19, 2024

The current behaviour of both commands is now deprecated and will be changed in a future breaking change release.
Both commands will be allowed to execute only inside dev console.

We recommend to run these commands from inside dev console starting from now.

@vvagaytsev
Copy link
Collaborator Author

This PR addresses the comment from #5733.

@vvagaytsev vvagaytsev force-pushed the improvement/deprecate-sync-start-stop branch from 983a1e5 to ab07b9b Compare February 21, 2024 15:37
core/src/commands/sync/sync-stop.ts Outdated Show resolved Hide resolved
@vvagaytsev vvagaytsev force-pushed the improvement/deprecate-sync-start-stop branch from ab07b9b to ca7e144 Compare March 4, 2024 08:57
@vvagaytsev vvagaytsev requested a review from eysi09 March 4, 2024 08:58
@vvagaytsev vvagaytsev added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit 6e1e979 Mar 4, 2024
40 checks passed
@vvagaytsev vvagaytsev deleted the improvement/deprecate-sync-start-stop branch March 4, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants