Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deletion of a node (True deletion API) #227

Closed
mpw96 opened this issue Jun 15, 2023 · 2 comments
Closed

Allow deletion of a node (True deletion API) #227

mpw96 opened this issue Jun 15, 2023 · 2 comments
Labels
status/closed Issue is closed (either delivered or triaged)

Comments

@mpw96
Copy link

mpw96 commented Jun 15, 2023

Which component are you using?:
cluster-autoscaler

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:
During a maintenance window I need to quickly move workload away from a workergroup with minimal service disruption for the customer. I also want to control the resource overhead. I want to taint (all nodes of) a workergroup and drain a couple of them. When draining them is finished, I'd like to drain the next chunk and so on.

Describe the solution you'd like.:
I'd like to be able (after draining a node) to delete it or have "someone" delete it. The most natural solution for me would be to just allow kubectl delete node some-node without the creation of some replacement node after some time. At the moment this does not work (see FAQ of cluster autoscaler and machine-controller-manager).

Describe any alternative solutions you've considered.:
Another solution would be something like setting an annotation on the node resource that tells Gardener, that I want to have this node deleted.

Additional context.:
Had a discussion with @dguendisch @rishabh-11 and others already.

@himanshu-kun himanshu-kun changed the title Allow deletion of a node Allow deletion of a node (True deletion API) Jul 18, 2023
@rishabh-11
Copy link

/close
Not required at the moment by the stakeholders

@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 30, 2024
@vlerenc
Copy link
Member

vlerenc commented Jun 7, 2024

Reason being, you can help around the initial problem with (e.g.):

   clusterAutoscaler:
      scaleDownDelayAfterAdd: 0s
      scaleDownDelayAfterDelete: 0s
      scaleDownDelayAfterFailure: 3m0s
      scaleDownUnneededTime: 30s
      scaleDownUtilizationThreshold: 0.5
      scanInterval: 10s
      expander: priority
      maxNodeProvisionTime: 6m0s
      maxGracefulTerminationSeconds: 600
      newPodScaleUpDelay: 0s
      maxEmptyBulkDelete: 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

No branches or pull requests

4 participants