Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gl-27] Install cifs-utils on existing nodes #15

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

vpnachev
Copy link
Member

@vpnachev vpnachev commented Sep 25, 2020

How to categorize this PR?

/area os
/kind enhancement
/priority normal
/os garden-linux

What this PR does / why we need it:
cifs-utils package will be installed even on existing Garden Linux 27.[0|1] nodes.

Which issue(s) this PR fixes:
Follow up on #14

Special notes for your reviewer:

Release note:

[Previously](https://github.com/gardener/gardener-extension-os-gardenlinux/pull/14/), `cifs-utils` was installed only on newly created Garden Linux nodes, now it is installed also on already existing nodes that are missing this package.

@vpnachev vpnachev requested a review from a team as a code owner September 25, 2020 12:05
@gardener-robot gardener-robot added area/os Operation system related kind/enhancement Enhancement, improvement, extension priority/normal labels Sep 25, 2020
@gardener-robot
Copy link

@vpnachev Label os/gardenlinux does not exist.

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 25, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 25, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 25, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 25, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 25, 2020
@gardener-robot gardener-robot added the os/garden-linux Related to Garden Linux OS label Sep 25, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 25, 2020
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Sep 25, 2020
@vpnachev vpnachev merged commit fb7b4bb into gardener:master Sep 25, 2020
@vpnachev vpnachev deleted the cifs-utils branch September 25, 2020 13:06
then
PARTITION=$(mount -v | grep "^/.*/usr" | awk '{print $1}')
mount -o remount,rw ${PARTITION} /usr
until apt update -qq && apt install --no-upgrade -qqy cifs-utils

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may cause issue on AliCloud because in China mainland, debian source network are not so stable

@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
LucaBernstein pushed a commit to LucaBernstein/gardener-extension-os-gardenlinux that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/os Operation system related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) os/garden-linux Related to Garden Linux OS reviewed/lgtm Has approval for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants