Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for MCM #287

Closed
1 of 6 tasks
prashanth26 opened this issue Jul 4, 2019 · 3 comments
Closed
1 of 6 tasks

Improvements for MCM #287

prashanth26 opened this issue Jul 4, 2019 · 3 comments
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related component/mcm Machine Controller Manager (including Node Problem Detector, Cluster Auto Scaler, etc.) effort/2d Effort for issue is around 2 days kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) platform/all priority/3 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged) topology/seed Affects Seed clusters

Comments

@prashanth26
Copy link
Contributor

prashanth26 commented Jul 4, 2019 •
edited
Loading

Issue

There are several optimizations identified for MCM to make it run better.

Solution

  • Eliminate all infinite for loops
  • Tag/mark machines while creation to identify each of them uniquely
  • Get rid of any GET calls before making UPDATES
  • Don't process on updated objects
  • Safety controller to be re-written with an event-based mechanism
  • Use pointers to struct. There is far too much implicit struct copying going on especially in range for loops.

Credits: @mvladev
@prashanth26 prashanth26 added kind/enhancement Enhancement, improvement, extension status/new Issue is new and unprocessed component/machine-controller-manager platform/all area/quality Output qualification (tests, checks, scans, automation in general, etc.) related size/s Size of pull request is small (see gardener-robot robot/bots/size.py) topology/seed Affects Seed clusters labels Jul 4, 2019
@amshuman-kr
Copy link

  • Use pointers to struct. There is far too much implicit struct copying going on especially in range for loops.

@gardener-robot-ci-1 gardener-robot-ci-1 added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Sep 2, 2019
@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Nov 2, 2019
@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jan 2, 2020
@ghost ghost added lifecycle/stale Nobody worked on this for 6 months (will further age) component/mcm Machine Controller Manager (including Node Problem Detector, Cluster Auto Scaler, etc.) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) component/machine-controller-manager labels Mar 2, 2020
@ghost ghost added the lifecycle/stale Nobody worked on this for 6 months (will further age) label May 7, 2020
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jul 7, 2020
@prashanth26 prashanth26 removed the lifecycle/rotten Nobody worked on this for 12 months (final aging stage) label Aug 13, 2020
@prashanth26
Copy link
Contributor Author

Things are getting better with #460. However, will keep this issue open to tracking exact improvements.

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Oct 13, 2020
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Dec 13, 2020
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) effort/2d Effort for issue is around 2 days and removed priority/normal labels Mar 8, 2021
@gardener-robot gardener-robot removed the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Mar 8, 2021
@himanshu-kun
Copy link
Contributor

/close
#724 An umbrella issue for tracking all MCM refactoring.

@gardener-robot gardener-robot added status/closed Issue is closed (either delivered or triaged) and removed status/new Issue is new and unprocessed labels Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related component/mcm Machine Controller Manager (including Node Problem Detector, Cluster Auto Scaler, etc.) effort/2d Effort for issue is around 2 days kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) platform/all priority/3 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged) topology/seed Affects Seed clusters
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@amshuman-kr @prashanth26 @gardener-robot-ci-1 @gardener-robot @himanshu-kun