Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hashicorp/terraform-provider-aws #86

Closed

Conversation

ialidzhikov
Copy link
Member

/kind enhancement

We have the following issues reported in the upstream terraform-provider-aws - hashicorp/terraform-provider-aws#12073 and hashicorp/terraform-provider-aws#12829. They were open for a quite long period of time. It seems that they are now both fixed (hopefully) in 3.34.0.

With the new versions of terraform-provider-aws I locally successfully validated the following scenarios:

  • reconciliation of existing Infrastructure
  • deletion of existing Infrastructure
  • creation and deletion of new Infrastructure (single zone, new vpc)
  • creation and deletion of new Infrastructure (multiple zones, new vpc)
  • creation and deletion of new Infrastructure (single zone, existing vpc)

Release note:

The following terraform provider plugin is updated:
- hashicorp/terraform-provider-aws: 3.32.0 -> 3.34.0

from 3.32.0 to 3.34.0

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov requested a review from a team as a code owner March 27, 2021 18:08
@gardener-robot gardener-robot added kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 27, 2021
@ialidzhikov
Copy link
Member Author

/cc @dguendisch

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 27, 2021
@ialidzhikov
Copy link
Member Author

I am closing this PR for as there is a change on terraform-provider-aws side that requires additional permissions - see #87. So we should first tackle the permission problem and its backwards-compatibility concerns before we proceed with this PR.

@ialidzhikov
Copy link
Member Author

/close

@ialidzhikov ialidzhikov deleted the enh/terraform-provider-aws branch July 13, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants