-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate JsonDecodeError
type with Data.Argonaut.Decode
#38
Comments
It's the other way around, the error type was copied from here to If we can figure out a decent resolution to the problem of wanting a slightly more open error type, talked about in purescript-contrib/purescript-argonaut-codecs#85 (there is discussion scattered in a few places too I think) and then make a library with just that type I'd switch to it though. |
It can be a concern for lib authors that would like to use Json/JsonDecodeError types and give users the freedom to choose a particular way they perform encoding/decoding (use codecs or codec). It seems like PureScript lacks a standardized approach to handling JSON, which is kind of a basic type for the main PS application. I believe you wanted to fix this with https://github.com/garyb/purescript-json? |
Yeah, exactly. I think most people do use It's not going to contain any opinion on codecs though, so it won't really have an impact on this problem. |
Just to clear things up, what is meant by "core" here? Is this Json type supposed to be standard like String and Array? |
It means the library will move under the main purescript organisation. |
@garyb hah ok, to me "go to core" sounded like something deep. Why modules there come under |
This module has its own
JsonDecodeError
type (that is just a copy of the code fromData.Argonaut.Decode.Error
), which makes modules incompatible. How this could be solved, with dependency on "argonaut-codes"?The text was updated successfully, but these errors were encountered: