Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More permissive version range for the @opentelemetry/instrumentation dependency #18

Open
amakhrov opened this issue Aug 16, 2024 · 4 comments

Comments

@amakhrov
Copy link

amakhrov commented Aug 16, 2024

Currently it's defined as

"@opentelemetry/instrumentation": "^0.46.0",

Note that since it's pre-1.0.0 version, it means the range of >=0.46.0 && <0.47.0
This is already behind the current version of opentelemetry (0.52.1 at this moment). It also misses some important (at least, to us) bug fixes from the latest opentelemetry version.

When used as a part of a larger solution (e.g. getsentry-js uses opentelemetry directly and also opentelemetry-instrumentation-fetch-node as an additional dep), it results in having two separate version of the opentelemetry in the project.

Is there a reason this package wouldn't work with the latest opentelemetry version?

@jd-carroll
Copy link

@timfish @mydea - I'm sure I already annoyed you enough earlier this year with ESM (which 🙏🏻 again). Would be great to get some updates here to allow for a more permissive range as @amakhrov has requested.

Note: I can't tell who actually owns this repo (or has commit priv)

@mydea
Copy link
Contributor

mydea commented Sep 4, 2024

Yeah, this is a general probem with @opentelemetry/instrumentation being pre-1 😬 Neither @timfish nor I maintain this package here, but it is an additional challenge for this package. IMHO the only thing that can be done for this package is to keep bumping the @opentelemetry/instrumentation dependency and releasing new versions every time 😬

@djMax
Copy link
Contributor

djMax commented Sep 4, 2024

I thought that the core team made a version based on this package but now "official." I can't find it from my phone here but maybe it's called undici instead?

@timfish
Copy link
Contributor

timfish commented Sep 4, 2024

There's @opentelemetry/instrumentation-undici and I'm in the process of migrating Sentry's Node SDK to use this after some previous PR's to bring it's config to the same level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants