-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gatsby Astronaut placeholder image #27
Add Gatsby Astronaut placeholder image #27
Conversation
Adding this image will allow users to add a relative src to add an image to their page in the Part 1 Tutorial here: https://www.gatsbyjs.org/tutorial/part-one/
de8d5ba
to
596501c
Compare
@tanvibhakta Would you be able to QA this change for me please? It will then unblock gatsbyjs/gatsby#9698 which will resolve gatsbyjs/gatsby#9655 👌🏻 |
Hello! I will do this in 48 hours, hope that's okay. My family celebrated
Deepavali so I'm trying not to use much tech today.
…On Mon, Nov 5, 2018, 6:43 PM Barry McGee ***@***.***> wrote:
@tanvibhakta <https://github.com/tanvibhakta> Would you be able to QA
this change for me please?
It will then unblock gatsbyjs/gatsby#9698
<gatsbyjs/gatsby#9698> which will resolve
gatsbyjs/gatsby#9655 <gatsbyjs/gatsby#9655>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ANID5oIa7CBWDkF9Ddt_fcEyOUA_4IgWks5usDl0gaJpZM4YM65g>
.
|
@tanvibhakta Sure, no problem! |
Hi there! Just following up on this, is it ready to merge? |
Hi @tanvibhakta, do you have any bandwidth this week to review this please? Maybe if you're super busy, @shannonbux could take a look? |
Hello everyone! Thanks for your hard work here and apologies for the time it took to reach a decision on this PR and the connected one (gatsbyjs/gatsby#9698). For now, I'm going to close this in favor of gatsbyjs/gatsby#9374 since a adding a page to the tutorial specifically on gatsby-image introduces a best practice. Thanks in advance for your patience with this idea; we only recently realized how few people know about gatsby-image and we'd like to use the tutorial as one of the ways to teach about it. It will be valuable to get your input on that new Here's the issue for cleaning those up! |
Adding this image will allow users to add a relative src to add an image to their page in the Part 1 Tutorial here: https://www.gatsbyjs.org/tutorial/part-one/
See discussion here: gatsbyjs/gatsby#9655
How to QA
npm install --global gatsby-cli
gatsby new gatsby-astronaut-pr https://github.com/barrymcgee/gatsby-starter-hello-world/
cd gatsby-astronaut-pr
npm start
src/pages/index.js
Switching back to your browser; http://localhost:8000/ should now look like the screenshot below;