Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gatsby Astronaut placeholder image #27

Closed

Conversation

barrymcgee
Copy link

@barrymcgee barrymcgee commented Nov 3, 2018

Adding this image will allow users to add a relative src to add an image to their page in the Part 1 Tutorial here: https://www.gatsbyjs.org/tutorial/part-one/

See discussion here: gatsbyjs/gatsby#9655

How to QA

  • If you haven't already, globally install the gatsby-cli; npm install --global gatsby-cli
  • Run: gatsby new gatsby-astronaut-pr https://github.com/barrymcgee/gatsby-starter-hello-world/
  • Drop into that folder; cd gatsby-astronaut-pr
  • Run the starter; npm start
  • View the site in your browser at; http://localhost:8000/
  • You should just see "Hello world"
  • Open the site folder in your editor and find; src/pages/index.js
  • Replace it's contents with;
import React from "react"

export default () => (
  <div style={{ color: `purple` }}>
    <h1>Hello Gatsby!</h1>
    <p>What a world.</p>
    <img src="./images/gatsby-astronaut.png" alt="The Gatsby Astronaut illustration" />
  </div>
)

Switching back to your browser; http://localhost:8000/ should now look like the screenshot below;

screenshot 2018-11-05 at 13 07 07

@barrymcgee barrymcgee closed this Nov 5, 2018
@barrymcgee barrymcgee deleted the add-placeholder-gatsby-image branch November 5, 2018 12:45
@barrymcgee barrymcgee restored the add-placeholder-gatsby-image branch November 5, 2018 12:45
@barrymcgee barrymcgee reopened this Nov 5, 2018
Adding this image will allow users to add a relative src to add an image to their page in the Part 1 Tutorial here: https://www.gatsbyjs.org/tutorial/part-one/
@barrymcgee barrymcgee force-pushed the add-placeholder-gatsby-image branch from de8d5ba to 596501c Compare November 5, 2018 12:53
@barrymcgee
Copy link
Author

barrymcgee commented Nov 5, 2018

@tanvibhakta Would you be able to QA this change for me please?

It will then unblock gatsbyjs/gatsby#9698 which will resolve gatsbyjs/gatsby#9655 👌🏻

@tanvibhakta
Copy link

tanvibhakta commented Nov 6, 2018 via email

@barrymcgee
Copy link
Author

barrymcgee commented Nov 6, 2018

@tanvibhakta Sure, no problem!

5pavp1k8_happy-diwali_625x300_06_november_18

@ebello
Copy link

ebello commented Nov 9, 2018

Hi there! Just following up on this, is it ready to merge?

@barrymcgee
Copy link
Author

Hi @tanvibhakta, do you have any bandwidth this week to review this please? Maybe if you're super busy, @shannonbux could take a look?

@shannonbux
Copy link

Hello everyone! Thanks for your hard work here and apologies for the time it took to reach a decision on this PR and the connected one (gatsbyjs/gatsby#9698). For now, I'm going to close this in favor of gatsbyjs/gatsby#9374 since a adding a page to the tutorial specifically on gatsby-image introduces a best practice. Thanks in advance for your patience with this idea; we only recently realized how few people know about gatsby-image and we'd like to use the tutorial as one of the ways to teach about it.

It will be valuable to get your input on that new gatsby-image tutorial and honestly, if any of you feels up to reviewing all the image-related docs and cleaning them up, they could use it!

Here's the issue for cleaning those up!
gatsbyjs/gatsby#4319

@shannonbux shannonbux closed this Nov 12, 2018
@barrymcgee barrymcgee deleted the add-placeholder-gatsby-image branch November 13, 2018 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants