Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Gatsby Image site uses Lorem Ipsum placeholder text #12947

Closed
robphoenix opened this issue Mar 29, 2019 · 1 comment · Fixed by #13170
Closed

Using Gatsby Image site uses Lorem Ipsum placeholder text #12947

robphoenix opened this issue Mar 29, 2019 · 1 comment · Fixed by #13170
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation

Comments

@robphoenix
Copy link
Contributor

robphoenix commented Mar 29, 2019

Summary

I noticed the site at https://using-gatsby-image.gatsbyjs.org/ currently uses Lorem Ipsum placeholder text, is there plans to update this to explanations of the different features of gatsby image? If so, is there any direction for what would make a useful PR to replace the current text?

@sidharthachatterjee sidharthachatterjee added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Apr 1, 2019
@sidharthachatterjee
Copy link
Contributor

Thank you for opening this @robphoenix

The home page at https://using-gatsby-image.gatsbyjs.org/ seems to have some documentation and links to https://www.gatsbyjs.org/packages/gatsby-image/ but the rest is placeholder text.

Updating the placeholder text to some explanation of the features used in context will be helpful and I can definitely see the value in it!

Would you like to open a PR? The relevant files are in https://github.com/gatsbyjs/gatsby/tree/master/examples/using-gatsby-image/ and the lorem text is coming from https://github.com/gatsbyjs/gatsby/blob/master/examples/using-gatsby-image/src/components/lorem.js

CC @marcysutton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants