Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expire old page data from production-app #13430

Closed
Moocar opened this issue Apr 17, 2019 · 3 comments
Closed

Expire old page data from production-app #13430

Moocar opened this issue Apr 17, 2019 · 3 comments

Comments

@Moocar
Copy link
Contributor

Moocar commented Apr 17, 2019

Depends on #13004

Once a page has been requested form the server, the page data stays around in browser memory until a refresh occurs. However, page data can change. If a user keeps a web page open for half an hour, and a piece of content has changed, then ideally, Gatsby should know to request the new data.

A half-way fix for this is to store the time that a page-data.json was requested from the server. And then, when calling loader.loadPage, we check if a certain amount of time (e.g 5 minutes) has elapsed, since we last loaded it, and if so, expire the old data and re-request from the server.

See #13409 (comment) for original comment.

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label May 9, 2019
@gatsbot
Copy link

gatsbot bot commented May 9, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contributefor more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@Moocar
Copy link
Contributor Author

Moocar commented May 9, 2019

Not stale

@gatsbot
Copy link

gatsbot bot commented May 20, 2019

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community!

@gatsbot gatsbot bot closed this as completed May 20, 2019
@KyleAMathews KyleAMathews added not stale and removed stale? Issue that may be closed soon due to the original author not responding any more. labels May 20, 2019
@KyleAMathews KyleAMathews reopened this May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants